netdev - Re: [Patch] rtnetlink: call ->dellink on failure when ->newlink exists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150215.083112.1760236558330375715.davem@davemloft.net>
Date:	Sun, 15 Feb 2015 08:31:12 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org, ignacy.gawedzki@...en-communications.fr
Subject: Re: [Patch] rtnetlink: call ->dellink on failure when ->newlink
 exists

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Fri, 13 Feb 2015 13:56:53 -0800

> Ignacy reported that when eth0 is down and add a vlan device
> on top of it like:
> 
>   ip link add link eth0 name eth0.1 up type vlan id 1
> 
> We will get a refcount leak:
> 
>   unregister_netdevice: waiting for eth0.1 to become free. Usage count = 2
> 
> The problem is when rtnl_configure_link() fails in rtnl_newlink(),
> we simply call unregister_device(), but for stacked device like vlan,
> we almost do nothing when we unregister the upper device, more work
> is done when we unregister the lower device, so call its ->dellink().
> 
> Reported-by: Ignacy Gawedzki <ignacy.gawedzki@...en-communications.fr>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html