lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87y4ny8rg2.fsf@rustcorp.com.au> Date: Mon, 16 Feb 2015 13:59:17 +1030 From: Rusty Russell <rusty@...tcorp.com.au> To: "Michael S. Tsirkin" <mst@...hat.com> Cc: lkml <linux-kernel@...r.kernel.org>, "netdev\@vger.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH 3/5] virtio: Don't expose legacy net features when VIRTIO_NET_NO_LEGACY defined. "Michael S. Tsirkin" <mst@...hat.com> writes: > On Sun, Feb 08, 2015 at 11:59:08AM +0100, Michael S. Tsirkin wrote: >> On Fri, Feb 06, 2015 at 03:36:54PM +1030, Rusty Russell wrote: >> > In particular, the virtio header always has the u16 num_buffers field. >> > We define a new 'struct virtio_net_modern_hdr' for this (rather than >> > simply calling it 'struct virtio_net_hdr', to avoid nasty type errors >> > if some parts of a project define VIRTIO_NET_NO_LEGACY and some don't. >> >> This kind of masks the fact that it's the same as >> virtio_net_hdr_mrg_rxbuf. So it's forcing people to duplicate >> code for transitional devices. >> >> How about >> struct virtio_net_modern_hdr { >> struct virtio_net_hdr_mrg_rxbuf hdr; >> } >> >> >> This will also make it look nicer when we start >> adding stuff in the header, the main header >> is separated in a struct by its own, so it's >> easy to apply operations such as sizeof. > > Ping. > Would you like a patch on top that does this? Hmm, I thought I replied... Indeed, I did. I disagreed, and simply renamed struct virtio_net_modern_hdr to virtio_net_hdr_v1. Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists