lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <54E1ECE6.60703@cogentembedded.com> Date: Mon, 16 Feb 2015 16:13:10 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Sathya Perla <Sathya.Perla@...lex.Com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH net-next 2/9] be2net: replace (1 << x) with BIT(x) Hello. On 2/16/2015 3:55 PM, Sathya Perla wrote: >>> From: Vasundhara Volam <vasundhara.volam@...lex.com> >>> BIT(x) is the preffered usage. >> Preferred. > :-) As this is a harmless spelling mistake only in the changelog, > I'll not bother sending a new patch for this! OK... >> [...] >>> diff --git a/drivers/net/ethernet/emulex/benet/be.h >> b/drivers/net/ethernet/emulex/benet/be.h >>> index 3b1d59d..9869556 100644 >>> --- a/drivers/net/ethernet/emulex/benet/be.h >>> +++ b/drivers/net/ethernet/emulex/benet/be.h >>> @@ -361,15 +361,15 @@ enum vf_state { >>> ASSIGNED = 1 >>> }; >>> >>> -#define BE_FLAGS_LINK_STATUS_INIT 1 >>> -#define BE_FLAGS_SRIOV_ENABLED (1 << 2) >>> -#define BE_FLAGS_WORKER_SCHEDULED (1 << 3) >>> -#define BE_FLAGS_VLAN_PROMISC (1 << 4) >>> -#define BE_FLAGS_MCAST_PROMISC (1 << 5) >>> -#define BE_FLAGS_NAPI_ENABLED (1 << 9) >>> -#define BE_FLAGS_QNQ_ASYNC_EVT_RCVD (1 << 11) >>> -#define BE_FLAGS_VXLAN_OFFLOADS (1 << 12) >>> -#define BE_FLAGS_SETUP_DONE (1 << 13) >>> +#define BE_FLAGS_LINK_STATUS_INIT BIT(1) >> Not BIT(0)? > Huh, this was not intentional. I'll remember to use bit-0 the next time > we introduce a new bit! Note that bit 0 was used for BE_FLAGS_LINK_STATUS_INIT before your patch. [...] WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists