netdev - Re: [PATCH] multicast: Extend ip address command to enable multicast group join/leave on IP level.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAN_zqfP1RB+jtyR_Gg4cac6BAxnbYC1kAtY6MmOXRPwh+8te8Q@mail.gmail.com>
Date:	Tue, 17 Feb 2015 11:06:44 -0800
From:	Madhu Challa <challa@...ronetworks.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] multicast: Extend ip address command to enable multicast
 group join/leave on IP level.

I realized we will have to do the same refactoring in ipv6 code as
well. I was also missing the mc_autojoin_sock initialization in ipv6
code that I just added. I will be happy to do the refactoring if you
want me to.

Thanks.

On Tue, Feb 17, 2015 at 8:08 AM, Madhu Challa <challa@...ronetworks.com> wrote:
>
>
> On Tue, Feb 17, 2015 at 3:10 AM, Eric Dumazet <eric.dumazet@...il.com>
> wrote:
>>
>> On Mon, 2015-02-16 at 14:20 -0800, Madhu Challa wrote:
>> > Joining multicast group on ethernet level via "ip maddr" command would
>> > not work if we have an Ethernet switch that does igmp snooping since
>> > the switch would not replicate multicast packets on ports that did not
>> > have IGMP reports for the multicast addresses.
>> >
>> ...
>> > +struct mc_autojoin_request {
>> > +     union {
>> > +             struct sockaddr_in sin;
>> > +             struct sockaddr_in6 sin6;
>> > +     } addr;
>> > +     int ifindex;
>> > +     struct sock *sk;
>> > +     struct work_struct ipv4_work;
>> > +     struct work_struct ipv6_work;
>> > +     bool join;
>> > +};
>>
>> This looks a net-next patch, right ?
>
>
> yes.
>>
>>
>> You do not need 2 separate work_struct. A single one is enough, or even
>> no work queue at all as a matter of fact.
>>
>> I'll send a preparation patch like this one, then you'll be able to call
>> __ip_mc_{join|leave}_group() directly while RTNL is held.
>>
>> [PATCH net-next] igmp: add __ip_mc_{join|leave}_group()
>>
>> There is a need to perform igmp join/leave operations while RTNL is
>> held. Make ip_mc_{join|leave}_group() wrappers around __ip_mc_{join|
>> leave}_group() to avoid the proliferation of work queues.
>
>
> Thanks. I will update my patch to use the new apis.
>
> Thanks.
>>
>>
>>
>>
>> ...
>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html