netdev - Re: [PATCH] colons are invalid characters in netdev names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54E3EBE5.5090008@mthode.org>
Date:	Tue, 17 Feb 2015 19:33:25 -0600
From:	Matthew Thode <mthode@...ode.org>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	davem@...emloft.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] colons are invalid characters in netdev names

On 02/17/2015 07:28 PM, Stephen Hemminger wrote:
> On Tue, 17 Feb 2015 17:15:42 -0600
> Matthew Thode <mthode@...ode.org> wrote:
> 
>> colons are used as a separator in netdev device lookup in dev_ioctl.c
>>
>> Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME
>>
>> Signed-off-by: Matthew Thode <mthode@...ode.org>
> 
> What is the exact sequence that causes the problem?
> SIOCSIFNAME already strips of colon.
> 
> 
It strips the name one access, not creation.  You can create a dummy
device and not access it, escaping doesn't seem to help.

ip link add name foo:asdasd type dummy
ip link del dev foo:asdasd              # will not be deleted

-- 
Matthew Thode


Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)