netdev - Re: Setting RPS affinities from network driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Feb 2015 21:17:20 +0530
From:	Sunil Kovvuri <sunil.kovvuri@...il.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	Linux Netdev List <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: Setting RPS affinities from network driver

Thanks Tom,

Will try to implement something like a library function which can be used
by any driver.

Regards,
Sunil.

On Wed, Feb 18, 2015 at 9:14 PM, Tom Herbert <therbert@...gle.com> wrote:
> On Tue, Feb 17, 2015 at 10:16 PM, Sunil Kovvuri <sunil.kovvuri@...il.com> wrote:
>> Hi,
>>
>> I am writing a network driver for a multicore SOC with a on-board
>> network interface and would like to set RPS affinities from driver by
>> default. So that the network performance is good with whatever driver
>> supplied. Ofcourse these can be further adjusted from userspace
>> anyways.
>>
>> Is there a way to set RPS settings from driver itself ?
>> The only issue i am seeing is while setting 'rps_needed' key.
>>
> There is nothing to prevent this, but it would be really cool to make
> this into a library function that drivers can call to initialize RPS
> in some sane way (you might want to look at cpu_rmap).
>
>> static_key_slow_inc(&rps_needed);
>>
>> Currently this is not exported, so having issues while compiling
>> driver as module.
>>
>> If i export this symbol, will it be acceptable ?
>>
> Seems okay to me.
>
> Thanks,
> Tom
>
>>
>> Thanks,
>> Sunil.
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html