netdev - RE: [patch] caif: fix a signedness bug in cfpkt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CAE5EE1@AcuExch.aculab.com>
Date:	Thu, 19 Feb 2015 09:49:00 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Dan Carpenter' <dan.carpenter@...cle.com>,
	Dmitry Tarnyagin <dmitry.tarnyagin@...kless.no>
CC:	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [patch] caif: fix a signedness bug in cfpkt_iterate()

From:  Dan Carpenter
...
> Also this isn't ever going to be inlined so I removed the "inline".
...
> -inline u16 cfpkt_iterate(struct cfpkt *pkt,
> -			 u16 (*iter_func)(u16, void *, u16),
> -			 u16 data)

static ??

> +int cfpkt_iterate(struct cfpkt *pkt,
> +		  u16 (*iter_func)(u16, void *, u16),
> +		  u16 data)

	David

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html