netdev - Re: [PATCH next] bonding: simple code refactor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Feb 2015 13:39:05 -0500
From:	Andy Gospodarek <gospo@...ulusnetworks.com>
To:	Mahesh Bandewar <maheshb@...gle.com>
Cc:	Jay Vosburgh <j.vosburgh@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Veaceslav Falico <vfalico@...il.com>,
	Nikolay Aleksandrov <nikolay@...hat.com>,
	David Miller <davem@...emloft.net>,
	Maciej Zenczykowski <maze@...gle.com>,
	netdev <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH next] bonding: simple code refactor

On Thu, Feb 19, 2015 at 10:13:25AM -0800, Mahesh Bandewar wrote:
> Remove duplicate code.
> 
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>

Looks good.

Signed-off-by: Andy Gospodarek <gospo@...ulusnetworks.com>

> ---
>  drivers/net/bonding/bond_main.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 19b12fbd808d..cbf77d388f53 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -2933,6 +2933,8 @@ static int bond_slave_netdev_event(unsigned long event,
>  			if (old_duplex != slave->duplex)
>  				bond_3ad_adapter_duplex_changed(slave);
>  		}
> +		/* Fallthrough */
> +	case NETDEV_DOWN:
>  		/* Refresh slave-array if applicable!
>  		 * If the setup does not use miimon or arpmon (mode-specific!),
>  		 * then these events will not cause the slave-array to be
> @@ -2944,10 +2946,6 @@ static int bond_slave_netdev_event(unsigned long event,
>  		if (bond_mode_uses_xmit_hash(bond))
>  			bond_update_slave_arr(bond, NULL);
>  		break;
> -	case NETDEV_DOWN:
> -		if (bond_mode_uses_xmit_hash(bond))
> -			bond_update_slave_arr(bond, NULL);
> -		break;
>  	case NETDEV_CHANGEMTU:
>  		/* TODO: Should slaves be allowed to
>  		 * independently alter their MTU?  For
> -- 
> 2.2.0.rc0.207.ga3a616c
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html