netdev - Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a modern way"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150219.152841.891912250243016754.davem@davemloft.net>
Date:	Thu, 19 Feb 2015 15:28:41 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	robert.jarzmik@...e.fr
Cc:	linus.walleij@...aro.org, nico@...xnic.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "smc91x: retrieve IRQ and trigger flags in a
 modern way"

From: Robert Jarzmik <robert.jarzmik@...e.fr>
Date: Fri, 13 Feb 2015 17:06:49 +0100

> Linus Walleij <linus.walleij@...aro.org> writes:
> 
>> On Fri, Feb 13, 2015 at 12:59 AM, Robert Jarzmik <robert.jarzmik@...e.fr> wrote:
>>
>> But isn't the real problem that in the device tree case,
>> irq_get_irq_data(ndev->irq) will work becaus parsing an interrupt
>> from the device tree populates it correctly in platform_get_irq()
>> whereas for the legacy lookup it just fetches the number.
>>
>> So to me it seems like a weakness in the platform_get_irq()
>> helper altogether.
>>
>> Does the following work? (I can send as a separate patch for
>> testing if you like).
> 
> Almost. If you replace :
>> +    if (r->flags & IORESOURCE_BITS)
> with:
>> +    if (r && r->flags & IORESOURCE_BITS)
> 
> Then you can push a patch with my:
> Tested-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> 
> Now if you can make it in -rc2 or -rc3, this revert should be forgotten. But if
> you can't make it for 3.20, I'll push for the revert.
> 
> So I think it's up to you now, and let's see what Gregh says about it.

What is the current status of this?  I'd like to see this move forward so we
can get this fixed ASAP.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html