netdev - Re: Possible Bug in gnet_start_copy_compat for the file,gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 19 Feb 2015 15:34:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	xerofoify@...il.com
Cc:	john.fastabend@...il.com, standby24x7@...il.com,
	xiyou.wangcong@...il.com, rdunlap@...radead.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Possible Bug in gnet_start_copy_compat for the file,gen_stats.c

From: nick <xerofoify@...il.com>
Date: Thu, 12 Feb 2015 21:33:16 -0500

> I am wondering after running sparse on the latest mainline tree why
> we are not unlocking the spinlock_bh,lock when calling the function,
> gnet_stats_start_copy_compat at the end of this function's
> body. Unless someone can explain to me why there is a very good
> reason for not unlocking the spinlock_bh,lock at the end of this
> function I will send in a patch fixing this. I am assuming this is a
> bug due to us infinitely looping in the spinlock_bh and deadlocking
> unless we exit this lock external to the call to the
> function,gnet_start_copy_compat.

This function is used to start a dump, and the caller needs the lock
to be held during the dump operation.

The lock is released by the caller by invoking gnet_stats_finish_copy().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html