netdev - Re: [Patch] gen_stats.c: Duplicate xstats buffer for later use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150219.154703.443300865954985533.davem@davemloft.net>
Date:	Thu, 19 Feb 2015 15:47:03 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org, ignacy.gawedzki@...en-communications.fr,
	David.Laight@...lab.com
Subject: Re: [Patch] gen_stats.c: Duplicate xstats buffer for later use

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Fri, 13 Feb 2015 14:47:05 -0800

> From: Ignacy Gawędzki <ignacy.gawedzki@...en-communications.fr>
> 
> The gnet_stats_copy_app() function gets called, more often than not, with its
> second argument a pointer to an automatic variable in the caller's stack.
> Therefore, to avoid copying garbage afterwards when calling
> gnet_stats_finish_copy(), this data is better copied to a dynamically allocated
> memory that gets freed after use.
> 
> [xiyou.wangcong@...il.com: remove a useless kfree()]
> 
> Signed-off-by: Ignacy Gawędzki <ignacy.gawedzki@...en-communications.fr>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Ugh, that's an ugly bug.

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html