| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Feb 2015 22:15:03 +0300
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To: Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org
CC: Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
netdev@...r.kernel.org, "Jan \"Yenya\" Kasprzak" <kas@...muni.cz>
Subject: Re: [PATCH 6/7 linux-next] wan: cosa: replace current->state by set_current_state()
On 02/20/2015 09:51 PM, Fabian Frederick wrote:
>>> Use helper functions to access current->state.
>>> Direct assignments are prone to races and therefore buggy.
>>> current->state = TASK_RUNNING is replaced by __set_current_state()
>> You sometimes use __set_current_state() and sometimes set_current_state().
> Hello Sergei,
> Peter suggested to use __set_current_state() for TASK_RUNNING :
> http://marc.info/?l=linux-kernel&m=142442259719216&w=2
I didn't even question your decisions, I (like Peter) just wanted a more
coherent change-log. Thanks to Peter for the explanations though. :-)
> Regards,
> Fabian
>>> Thanks to Peter Zijlstra for the exact definition of the problem.
>>> Suggested-By: Peter Zijlstra <peterz@...radead.org>
>>> Signed-off-by: Fabian Frederick <fabf@...net.be>
>> [...]
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists