netdev - Re: [PATCH] ethernet/ixp4xx: prevent allmulti from clobbering promisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150220.154927.313372314025203773.davem@davemloft.net>
Date:	Fri, 20 Feb 2015 15:49:27 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	pallas@...aki.com
Cc:	khalasa@...p.pl, netdev@...r.kernel.org
Subject: Re: [PATCH] ethernet/ixp4xx: prevent allmulti from clobbering
 promisc

From: Derrick Pallas <pallas@...aki.com>
Date: Wed, 18 Feb 2015 00:50:25 -0800

> If both promisc and allmulti are set, promisc should trump allmulti and
> disable the MAC filter; otherwise, the interface is not really promisc.
> 
> Previously, this code checked IFF_ALLMULTI prior to and without regard for
> IFF_PROMISC; if both were set, only multicast and direct unicast traffic
> would make it through the filter.
> 
> Signed-off-by: Derrick Pallas <pallas@...aki.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html