netdev - Re: [PATCH] pppoe: Use workqueue to die properly when a PADT is received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2335170.7Jqfc2NRFK@hummingbird.farnz.org.uk>
Date:	Fri, 20 Feb 2015 21:04:53 +0000
From:	Simon Farnsworth <simon@...nz.org.uk>
To:	Christoph Schulz <develop@...stov.de>
Cc:	netdev@...r.kernel.org, Dan Williams <dcbw@...hat.com>,
	mostrows@...il.com, linux-ppp@...r.kernel.org
Subject: Re: [PATCH] pppoe: Use workqueue to die properly when a PADT is received

On Friday 20 February 2015 20:49:23 Christoph Schulz wrote:
> Hello!
> 
> Simon Farnsworth schrieb am Fri, 20 Feb 2015 16:41:17 +0000:
> >> Feb 20 16:45:44 sandbox local2.err pppd[539]: Failed to disconnect
> >> PPPoE socket: 114 Operation already in progress
> > 
> > I assume there's nothing else wrong here, other than pppd complaining? The
> > code doesn't suggest there will be issues if we fail to disconnect.
> 
> Yes, there are no further problems beside the message. Nevertheless I
> wanted to mention it because any error message containing something
> like "Failed to disconnect" may upset the user. Of course, most PPPoE
> users nowadays use a flat rate for accessing the Internet and need not
> worry much about a "failed" disconnection, but you never know for
> sure...
> 
I've now looked at the kernel code; the message is harmless, as closing the 
socket will also get rid of the associated session.

However, I think I should probably do a v2 patch with a clear commit message, 
so that if someone does bisect down to this commit as a cause of the "error" 
they're seeing, they'll understand why it's not a problem.

I'll also put together a pppd patch to not change session ID during shutdown. 
Won't be tonight - but that's no bad thing as it leaves time for more 
reviewers to comment on my kernel patch.
-- 
Simon Farnsworth
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)