netdev - Re: [PATCH net-next v3 0/2] iproute2: bridge vlan range support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE4R7bAG5RMP6=8KKA_W4kxAHy5vsavtccRbD5j03cSYS0a4jQ@mail.gmail.com>
Date:	Fri, 20 Feb 2015 00:09:17 -0500
From:	Scott Feldman <sfeldma@...il.com>
To:	roopa <roopa@...ulusnetworks.com>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	Netdev <netdev@...r.kernel.org>, shemminger@...tta.com,
	"vyasevic@...hat.com" <vyasevic@...hat.com>,
	Wilson Kok <wkok@...ulusnetworks.com>,
	Jamal Hadi Salim <hadi@...atatu.com>,
	Andy Gospodarek <gospo@...ulusnetworks.com>
Subject: Re: [PATCH net-next v3 0/2] iproute2: bridge vlan range support

On Thu, Feb 19, 2015 at 9:08 PM, roopa <roopa@...ulusnetworks.com> wrote:
> On 2/5/15, 10:48 AM, Stephen Hemminger wrote:
>>
>> On Sun, 25 Jan 2015 18:26:23 -0800
>> roopa@...ulusnetworks.com wrote:
>>
>>> From: Roopa Prabhu <roopa@...ulusnetworks.com>
>>>
>>> This series adds support for vlan ranges in iproute2 bridge add
>>> and show commands.
>>>
>>> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
>>> Signed-off-by: Wilson Kok <wkok@...ulusnetworks.com>
>>>
>>> Roopa Prabhu (2):
>>>    iproute2: bridge: support vlan range for adds
>>>    iproute2: bridge vlan show new option to print ranges
>>>
>>>   bridge/br_common.h        |    1 +
>>>   bridge/bridge.c           |    6 ++++-
>>>   bridge/vlan.c             |   55
>>> ++++++++++++++++++++++++++++++++++++++++-----
>>>   include/linux/if_bridge.h |    2 ++
>>>   include/linux/rtnetlink.h |    1 +
>>>   5 files changed, 58 insertions(+), 7 deletions(-)
>>>
>> Applied to net-next branch of iproute2
>> Go ahead and send more patches if you decide on different output format.
>
>
> Thanks stephen.
>
> Maybe too late, but wanted to add a note.
> I would have loved to have the default output print vlan ranges if the
> iproute2 version is capable and is talking to the kernel which has vlan
> range support. The netlink msg handling takes care of back ward
> compatibility.
>
> I think, I was being too cautious to not break users who might be doing
> screen scraping.
> In general should i be too worried about breaking such users ?.
> If not, I would love to resubmit the patch to make the default output print
> ranges.

+1, if not worried about breaking such users.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html