netdev - RE: [PATCH net 1/3] rhashtable: don't test for shrink on insert, expansion on delete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CAE675F@AcuExch.aculab.com>
Date:	Fri, 20 Feb 2015 10:08:26 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Daniel Borkmann' <daniel@...earbox.net>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"tgraf@...g.ch" <tgraf@...g.ch>,
	"johunt@...mai.com" <johunt@...mai.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Ying Xue <ying.xue@...driver.com>
Subject: RE: [PATCH net 1/3] rhashtable: don't test for shrink on insert,
 expansion on delete

From: Daniel Borkmann
> Restore pre 54c5b7d311c8 behaviour and only probe for expansions on inserts
> and shrinks on deletes. Currently, it will happen that on initial inserts
> into a sparse hash table, we may i.e. shrink it first simply because it's
> not fully populated yet, only to later realize that we need to grow again.
> 
> This however is counter intuitive, e.g. an initial default size of 64
> elements is already small enough, and in case an elements size hint is given
> to the hash table by a user, we should avoid unnecessary expansion steps,
> so a shrink is clearly unintended here.

Does it actually make sense to shrink below the initial default size?

	David

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html