netdev - Re: [PATCH] pppoe: Use workqueue to die properly when a PADT is received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3411251.Z29qxOyJF6@f19simon>
Date:	Fri, 20 Feb 2015 11:17:26 +0000
From:	Simon Farnsworth <simon@...nz.org.uk>
To:	netdev@...r.kernel.org, Dan Williams <dcbw@...hat.com>
Subject: Re: [PATCH] pppoe: Use workqueue to die properly when a PADT is received

Michal's e-mail as listed in MAINTAINERS is bouncing (he's listed as PPPoE
maintainer).

If anyone has alternate contact details for him, please let him know that
his kernel-related e-mail is bouncing.

The relevant chunk of MAINTAINERS is:

PPP OVER ETHERNET
M:      Michal Ostrowski <mostrows@...thlink.net>
S:      Maintained
F:      drivers/net/ppp/pppoe.c
F:      drivers/net/ppp/pppox.c

If I don't hear from him in the next couple of weeks, I'll send the trivial
patch to remove PPP OVER ETHERNET from maintained status.

On Thursday 19 February 2015 21:24:28 Simon Farnsworth wrote:
> When a PADT frame is received, the socket may not be in a good state to
> close down the PPP interface. The current implementation handles this by
> simply blocking all further PPP traffic, and hoping that the lack of traffic
> will trigger the user to investigate.
> 
> Use schedule_work to get to a process context from which we clear down the
> PPP interface, in a fashion analogous to hangup on a TTY-based PPP
> interface. This causes pppd to disconnect immediately, and allows tools to
> take immediate corrective action.
> 
> Signed-off-by: Simon Farnsworth <simon@...nz.org.uk>
> ---
> Note that I'm not subscribed to netdev; please cc me on any replies.
> 
> The patch falls out of https://bugzilla.gnome.org/show_bug.cgi?id=742939
> I'm trying to get NetworkManager back to using kernel PPPoE partly because
> it performs a little better, and mostly because kernel PPPoE copes with
> larger MTUs than userspace PPPoE.
> 
> Dan Williams (cc'd) has tested a previous version of this patch; the
> differences to this version are only cosmetic.
> 
>  drivers/net/ppp/pppoe.c  | 17 ++++++++++++++++-
>  include/linux/if_pppox.h |  2 ++
>  2 files changed, 18 insertions(+), 1 deletion(-)
> 
<snip patch>

--
Simon Farnsworth

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)