netdev - Re: [PATCH next v6 3/5] bonding: Allow userspace to set actors' system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF2d9jgfe5phyjPC+iYQhqp0=10gg2bfFs4=Nk2xyMtQvFsfaw@mail.gmail.com>
Date:	Fri, 20 Feb 2015 08:50:11 -0800
From:	Mahesh Bandewar <maheshb@...gle.com>
To:	Andy Gospodarek <gospo@...ulusnetworks.com>
Cc:	Jay Vosburgh <jay.vosburgh@...onical.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Veaceslav Falico <vfalico@...il.com>,
	Nikolay Aleksandrov <nikolay@...hat.com>,
	David Miller <davem@...emloft.net>,
	Maciej Zenczykowski <maze@...gle.com>,
	netdev <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH next v6 3/5] bonding: Allow userspace to set actors'
 system_priority in AD system

On Thu, Feb 19, 2015 at 7:25 PM, Andy Gospodarek
<gospo@...ulusnetworks.com> wrote:
> On Thu, Feb 19, 2015 at 01:39:22PM -0800, Jay Vosburgh wrote:
>>
>>       [ Sorry, I hadn't read v6 earlier; resending for the current
>> version so it is filed properly in patchwork... ]
>>
>> Mahesh Bandewar <maheshb@...gle.com> wrote:
>>
>> >This patch allows user to randomize the system-priority in an ad-system.
>> >The allowed range is 1 - 0xFFFF while default value is 0xFFFF. If user
>> >does not specify this value, the system defaults to 0xFFFF, which is
>> >what it was before this patch.
>> >
>> >Following example code could set the value -
>> >    # modprobe bonding mode=4
>> >    # sys_prio=$(( 1 + RANDOM + RANDOM ))
>> >    # echo $sys_prio > /sys/class/net/bond0/bonding/ad_actor_sys_prio
>> >    # echo +eth1 > /sys/class/net/bond0/bonding/slaves
>> >    ...
>> >    # ip link set bond0 up
>> >
>> >Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
>> >Reviewed-by: Nikolay Aleksandrov <nikolay@...hat.com>
>>
>>       Mahesh: Andy and I got together at netdev01 and discussed the
>> patches of this series that add options to sysfs for bonding (patches 3,
>> 4, and 5).  In summary, in my opinion a netlink / iproute2 interface
>> needs to be provided simultaneously with any new sysfs interface for
>> bonding.  I realize that the sysfs api to bonding won't go away, but
>> nevertheless users should be encouraged to use netlink preferentially.
>> Providing the api pieces together encourages this.
>>
>>       As it happens, Andy mentioned that he has patches similar to
>> these three, but with the netlink portion already implemented.
>>
>>       My suggestion here is therefore for Andy to post his patches,
>> and then we can merge these together, and get this implemented properly
>> with a minimum of duplicated effort.
>
> Yes, I would be happy to integrate our netlink patches with these.
> Mahesh, do you want me to send these to you and have you manage all of
> this, or do you want me to just integrate this latest version with mine
> and re-submit all of them?
>
Go ahead and re-submit them all. Thanks Andy.
>>
>>         -J
>>
>> ---
>>       -Jay Vosburgh, jay.vosburgh@...onical.com
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html