lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 21 Feb 2015 19:33:59 +0100
From:	Sabrina Dubroca <>
To:	Madalin Bucur <>
Subject: Re: [PATCH] ipv6: address issue in __ip6_append_data

2015-02-13, 17:30:59 +0200, Madalin Bucur wrote:
> Hello,
> I think I've found a problem that allows generic IPv6 traffic to be
> sent by the stack with CHECKSUM_PARTIAL to a netdevice that declares
> NETIF_F_IPV6_CSUM. The NETIF_F_IPV6_CSUM flag is based on the
> NETIF_F_IPV6_CSUM_BIT that is described as referring only to TCP and
> UDP but in my test ICMPv6 frames with CHECKSUM_PARTIAL are seen:

This should be fixed by:

    bf250a1fa769 ("ipv6: Partial checksum only UDP packets")

Have you tested it?

> NETIF_F_IPV6_CSUM_BIT,          /* Can checksum TCP/UDP over IPV6 */
> I've traced the issue to a recent commit that includes this check:
> 	rt->>features & NETIF_F_V6_CSUM
> The problem with this is that NETIF_F_V6_CSUM is more than one bit:
> Thus the above check should be either:
> 	(rt->>features & NETIF_F_V6_CSUM) == NETIF_F_V6_CSUM

I think this disables HW checksumming that Vlad's patch enabled.  As
Vlad pointed out in another similar thread [1], the two bits are
mutually exclusive, so you can't have

    (dev->features & NETIF_F_V6_CSUM) == NETIF_F_V6_CSUM


> or probably should use NETIF_F_HW_CSUM only:
> 	rt->>features & NETIF_F_HW_CSUM

Maybe.  But I just tried this, and it doesn't work with qemu's e1000
emulation (could be a driver/qemu problem, I can't check with other

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists