netdev - Re: [PATCH net-next 1/2] dsa: bonding: implement HW bonding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bCme-O6kkCWgmK_XXXfyi_uej8SvbVzDY7Q+WFp2STyRA@mail.gmail.com>
Date:	Sat, 21 Feb 2015 13:12:28 -0800
From:	Scott Feldman <sfeldma@...il.com>
To:	Jonas Johansson <jonasj76@...il.com>
Cc:	Netdev <netdev@...r.kernel.org>,
	Jonas Johansson <jonas.johansson@...termo.se>,
	Roopa Prabhu <roopa@...ulusnetworks.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Andy Gospodarek <gospo@...ulusnetworks.com>,
	Jiří Pírko <jiri@...nulli.us>
Subject: Re: [PATCH net-next 1/2] dsa: bonding: implement HW bonding

On Fri, Feb 20, 2015 at 2:51 AM, Jonas Johansson <jonasj76@...il.com> wrote:
> From: Jonas Johansson <jonas.johansson@...termo.se>
>
> This patch will implement hooks for hardware bonding support for the DSA
> driver. When the team driver adds a DSA slave port the port will be assigned
> a bond group id and the DSA slave driver can setup the hardware. When team
> changes the port state (enabled/disabled) the DSA slave driver is able to
> use the attach/detach callback which will allow the hardware to change the
> hardware settings to reflect the state.
>
> Added DSA hooks:
>  bond_add_group: To add a port to a bond group
>  bond_del_group: To remove a port from a bond group
>  bond_attach: To mark the port in a bond group as attached/active
>  bond_detach: To unmark the port in a bond group as detach/inactive
>
> Added new network device hooks:
>  ndo_bond_attach: To attach a device to a bond group.
>  ndo_bond_detach: To detach a device from a bond group.
>
> Team:
>  Added callback to ndo_bond_attach when port is enabled.
>  Added callback to ndo_bond_detach when port is disabled.
>
> Added DSA notifier:
>  Listening on NETDEV_CHANGEUPPER to add or deleta a port to/from a bond group.

Hi Jonas,

Cc:'ing Andy as he mentioned at netdev01 he was looking into something
similar for switchdev.

My comments are along the lines of the others:

Can we up-level this not for just DSA but for switchdev in general?  I
think the requirements are:

1) It should work for team or bonding.

2) Port driver needs to know a) bond membership, and b) port (active,
inactive) status, at least for 802.3ad.

3) Try to avoid adding new ndo ops if possible, and rather use what's there.

It took me a bit to figure out your new ndo ops in this patch.  Going
by the name ndo_bond_attach/dettach, I thought these were for port
membership, but you're using them for port status change.  So the name
was confusing.  Since you already have port membership covered with
netdevice event NETDEV_CHANGEUPPER, can we also adapt port status
change into netdevice event NETDEV_BONDING_INFO?  (See
netdev_bonding_info_change()).

-scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html