netdev - Re: [PATCH] rhashtable: initialize all rhashtable walker members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54EA49E5.8040206@oracle.com>
Date:	Sun, 22 Feb 2015 16:28:05 -0500
From:	Sasha Levin <sasha.levin@...cle.com>
To:	David Miller <davem@...emloft.net>
CC:	herbert@...dor.apana.org.au, tgraf@...g.ch, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rhashtable: initialize all rhashtable walker members

On 02/22/2015 03:58 PM, David Miller wrote:
> From: Sasha Levin <sasha.levin@...cle.com>
> Date: Sat, 21 Feb 2015 15:55:11 -0500
> 
>> Commit "rhashtable: Introduce rhashtable_walk_*" forgot to initialize the
>> members of struct rhashtable_walker after allocating it, which caused
>> an undefined value for 'resize' which is used later on.
>>
>> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>
> 
> Commits should be referred to by SHA1 ID as well as the commit
> header text (in parenthesis and double quotes).

It wasn't (isn't?) in Linus' tree yet, so I didn't want to refer to
it by a SHA1 ID which would change.

> Even better, refer to the commit using a "Fixes: " tag right before
> your signoff.

Ok, should I resend?


Thanks,
Sasha

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html