netdev - Re: [PATCH net-next v3 3/4] net: use skb->priority for overloading skb->dropcount and skb->reserved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1424721111.5565.66.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 23 Feb 2015 11:51:51 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Eyal Birger <eyal.birger@...il.com>
Cc:	Shmulik Ladkani <shmulik.ladkani@...il.com>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 3/4] net: use skb->priority for overloading
 skb->dropcount and skb->reserved_tailroom instead of skb->mark

On Mon, 2015-02-23 at 21:25 +0200, Eyal Birger wrote:

> The original commit introducing dropcount for af_packet
> (see http://marc.info/?l=linux-netdev&m=125450261121971) also claimed
> the proper location would in fact be skb->cb[]. However, it was also
> claimed that
> skb->cb[] is all used up.
> 
> Things are even more complicated now as dropcount became a socket
> level feature and skb->cb[] is handled differently in each protocol family.

I did a check, and all current sock_recv_ts_and_drops() users have room
in skb->cb[] to store dropcount, say at the beginning of the array.

I have no big opinion here, but intuitively dropcount has a very short
lifetime and skb->cb[] seems appropriate.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html