netdev - Re: [PATCH net-next v3 2/2] multicast: Extend ip address command to enable multicast group join/leave on IP level.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 22 Feb 2015 23:55:15 -0800
From:	Madhu Challa <challa@...ronetworks.com>
To:	YOSHIFUJI Hideaki <hideaki.yoshifuji@...aclelinux.com>
Cc:	netdev@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com>,
	davem@...emloft.net
Subject: Re: [PATCH net-next v3 2/2] multicast: Extend ip address command to
 enable multicast group join/leave on IP level.

On Sun, Feb 22, 2015 at 11:44 PM, YOSHIFUJI Hideaki
<hideaki.yoshifuji@...aclelinux.com> wrote:
> Hi,
>
> Madhu Challa wrote:
>
>> diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
>> index 3a8985c..ee56730 100644
>> --- a/net/ipv4/devinet.c
>> +++ b/net/ipv4/devinet.c
>
>> @@ -838,6 +864,16 @@ static int inet_rtm_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh)
>>                * userspace already relies on not having to provide this.
>>                */
>>               set_ifa_lifetime(ifa, valid_lft, prefered_lft);
>> +             if (ifa->ifa_flags & IFA_F_MCAUTOJOIN) {
>> +                     WARN_ON(!ipv4_is_multicast(ifa->ifa_address));
>> +                     ret = ip_mc_config(net->ipv4.mc_autojoin_sock,
>> +                                        true, ifa->ifa_address,
>> +                                        ifa->ifa_dev->dev->ifindex);
>> +                     if (ret < 0) {
>> +                             inet_free_ifa(ifa);
>> +                             return ret;
>> +                     }
>> +             }
>
> No WARN_ON() here, please.

Good point. It should never happen because the "ip command" would not
allow autojoin with a non multicast address. However in v1 of the
patch I was doing this via a workqueue and could not return an error.
Its not a problem anymore since ip_mc_config can return an error. I
will remove it. I will wait till tomorrow to see if there are any
other comments.

Thanks.
>
>
>> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
>> index 98e4a63..b9b6d52 100644
>> --- a/net/ipv6/addrconf.c
>> +++ b/net/ipv6/addrconf.c
>> @@ -2501,6 +2519,14 @@ static int inet6_addr_add(struct net *net, int ifindex,
>>       if (IS_ERR(idev))
>>               return PTR_ERR(idev);
>>
>> +     if (ifa_flags & IFA_F_MCAUTOJOIN) {
>> +             WARN_ON(!ipv6_addr_is_multicast(pfx));
>> +             ret = ipv6_mc_config(net->ipv6.mc_autojoin_sock,
>> +                                  true, pfx, ifindex);
>> +             if (ret < 0)
>> +                     return ret;
>> +     }
>> +
>>       scope = ipv6_addr_scope(pfx);
>>
>>       timeout = addrconf_timeout_fixup(valid_lft, HZ);
>
> ditto.
>
> --
> Hideaki Yoshifuji <hideaki.yoshifuji@...aclelinux.com>
> Technical Division, MIRACLE LINUX CORPORATION
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html