lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Feb 2015 16:42:19 +0000 From: Thomas Graf <tgraf@...g.ch> To: Josh Hunt <johunt@...mai.com> Cc: Pablo Neira Ayuso <pablo@...filter.org>, Patrick McHardy <kaber@...sh.net>, netfilter-devel@...r.kernel.org, netdev@...r.kernel.org, Daniel Borkmann <daniel@...earbox.net> Subject: Re: [PATCH v2 2/2] nft_hash: define max_shift rhashtable parameter On 02/24/15 at 11:10am, Josh Hunt wrote: > You must define a max_shift parameter to rhashtable or else the table cannot > grow. This sets max_shift for nft_hash to 24, which will allow the table to > grow to 2^24 or 16 million buckets. > > Signed-off-by: Josh Hunt <johunt@...mai.com> > --- > net/netfilter/nft_hash.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/net/netfilter/nft_hash.c b/net/netfilter/nft_hash.c > index 61e6c40..839ed30 100644 > --- a/net/netfilter/nft_hash.c > +++ b/net/netfilter/nft_hash.c > @@ -23,6 +23,9 @@ > /* We target a hash table size of 4, element hint is 75% of final size */ > #define NFT_HASH_ELEMENT_HINT 3 > > +/* Set default of 2^24 buckets or 16 million entries */ > +#define NFT_HASH_MAX_ELEMENTS 24 Maybe this should be called .._MAX_BUCKETS instead, the table itself does not have a upper nelements limit but will not grow above 16M buckets as the comment states correctly already. After this change: Acked-by: Thomas Graf <tgraf@...g.ch> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists