netdev - Re: [RESEND PATCH] af_packet: don't pass empty blocks for PACKET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150224.160958.1491397927638460390.davem@davemloft.net>
Date:	Tue, 24 Feb 2015 16:09:58 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	al.drozdov@...il.com
Cc:	dborkman@...hat.com, edumazet@...gle.com, viro@...iv.linux.org.uk,
	willemb@...gle.com, mst@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, dan@...llins.co.nz, guy@...m.mit.edu
Subject: Re: [RESEND PATCH] af_packet: don't pass empty blocks for PACKET_V3

From: Alexander Drozdov <al.drozdov@...il.com>
Date: Tue, 24 Feb 2015 08:18:28 +0300

> Before da413eec729d ("packet: Fixed TPACKET V3 to signal poll when block is
> closed rather than every packet") poll listening for an af_packet socket was
> not signaled if there was no packets to process. After the patch poll is
> signaled evety time when block retire timer expires. That happens because
> af_packet closes the current block on timeout even if the block is empty.
> 
> Passing empty blocks to the user not only wastes CPU but also wastes ring
> buffer space increasing probability of packets dropping on small timeouts.
> 
> Signed-off-by: Alexander Drozdov <al.drozdov@...il.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html