netdev - RE: [E1000-devel] [PATCH v2 3/3] ixgbe: Add new ndo to allow VF multicast promiscuous mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD05E3F1D9@BPXM14GP.gisp.nec.co.jp>
Date:	Tue, 24 Feb 2015 23:43:32 +0000
From:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
To:	"Tantilov, Emil S" <emil.s.tantilov@...el.com>,
	"Skidmore, Donald C" <donald.c.skidmore@...el.com>,
	"vyasevic@...hat.com" <vyasevic@...hat.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Choi, Sy Jong" <sy.jong.choi@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Laight <David.Laight@...LAB.COM>,
	Hayato Momma <h-momma@...jp.nec.com>,
	Bj┆rn Mork <bjorn@...k.no>
Subject: RE: [E1000-devel] [PATCH v2 3/3] ixgbe: Add new ndo to allow VF
 multicast promiscuous mode

> >-----Original Message-----
> >From: Hiroshi Shimamoto [mailto:h-shimamoto@...jp.nec.com]
> >Sent: Thursday, February 19, 2015 5:01 PM
> > Subject: [E1000-devel] [PATCH v2 3/3] ixgbe: Add new ndo to allow VF multicast promiscuous mode
> >
> >From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
> >
> >Implements the new netdev op to allow VF multicast promiscuous mode.
> >
> >The administrator can allow to VF multicast promiscuous mode for only
> >trusted VM. After allowing multicast promiscuous mode from the host,
> >we can use over 30 IPv6 addresses on VM.
> > # ./ip link set dev eth0 vf 1 mc_promisc on
> >
> >When disallowing multicast promiscuous mode, we can only use 30 IPv6 addresses.
> > # ./ip link set dev eth0 vf 1 mc_promisc off
> >
> >Signed-off-by: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
> >Reviewed-by: Hayato Momma <h-momma@...jp.nec.com>
> >CC: Choi, Sy Jong <sy.jong.choi@...el.com>
> 
> <snip>
> 
> +int ixgbe_ndo_set_vf_mc_promisc(struct net_device *netdev, int vf, bool setting)
> +{
> +	struct ixgbe_adapter *adapter = netdev_priv(netdev);
> +	struct ixgbe_hw *hw = &adapter->hw;
> +	u32 vmolr;
> 
> vmolr is unused variable in this function.
> 
> +
> +	if (vf >= adapter->num_vfs)
> +		return -EINVAL;
> +
> +	/* nothing to do */
> +	if (adapter->vfinfo[vf].mc_promisc_allowed == setting)
> +		return 0;
> +
> +	adapter->vfinfo[vf].mc_promisc_allowed = setting;
> +
> +	/* if VF requests multicast promiscuous */
> +	if (adapter->vfinfo[vf].mc_promisc) {
> +		if (setting)
> +			ixgbe_enable_vf_mc_promisc(adapter, vf);
> +		else
> +			ixgbe_disable_vf_mc_promisc(adapter, vf);
> +	}
> +
> +	return 0;
> +}

thank you for pointing it.
I realized it and am preparing a patch.

thanks,
Hiroshi