lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <54EC4801.3080407@linn.co.uk> Date: Tue, 24 Feb 2015 09:44:33 +0000 From: Stathis Voukelatos <stathis.voukelatos@...n.co.uk> To: David Miller <davem@...emloft.net> CC: <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>, <devicetree@...r.kernel.org> Subject: Re: [PATCH v3 3/3] Linn Ethernet packet sniffer driver On 23/02/15 21:38, David Miller wrote: > From: Stathis Voukelatos <stathis.voukelatos@...n.co.uk> > Date: Mon, 23 Feb 2015 14:26:22 +0000 > >> Driver for the Ethernet Mii packet sniffer H/W module found in >> the IMG Pistachio SoC. >> >> Signed-off-by: Stathis Voukelatos <stathis.voukelatos@...n.co.uk> > > You really have to explain what this thing does, how it is used, > what APIs are made use of to maniulate this device, etc. > > Nobody knows what the packet sniffer module by your company is. > I tried to provide a description of the device in the cover letter. I will expand it and also include it in a suitable place in the actual source. > I also anticipate that once you describe adequately how this thing > behaves I won't like it, and I'll prefer that you integrate support > for your device using an exising facility such as AF_PACKET, > extending it if need be. > The driver actually relies on AF_PACKET for accessing the device. I will add some documentation to make the usage and API clearer. > I am very far away from applying this series at this point, it needs > a lot more work and explanations. > Thank you, Stathis -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists