netdev - Re: [PATCHv1 net] xen-netback: release pending index before pushing Tx responses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150224120324.GH20083@zion.uk.xensource.com>
Date:	Tue, 24 Feb 2015 12:03:24 +0000
From:	Wei Liu <wei.liu2@...rix.com>
To:	David Vrabel <david.vrabel@...rix.com>
CC:	<netdev@...r.kernel.org>, <xen-devel@...ts.xenproject.org>,
	Ian Campbell <ian.campbell@...rix.com>,
	Wei Liu <wei.liu2@...rix.com>
Subject: Re: [PATCHv1 net] xen-netback: release pending index before pushing
 Tx responses

On Tue, Feb 24, 2015 at 11:17:59AM +0000, David Vrabel wrote:
> If the pending indexes are released /after/ pushing the Tx response
> then a stale pending index may be used if a new Tx request is
> immediately pushed by the frontend.  The may cause various WARNINGs or
> BUGs if the stale pending index is actually still in use.
> 
> Fix this by releasing the pending index before pushing the Tx
> response.
> 
> The full barrier for the pending ring update is not required since the
> the Tx response push already has a suitable write barrier.
> 
> Signed-off-by: David Vrabel <david.vrabel@...rix.com>

Reviewed-by: Wei Liu <wei.liu2@...rix.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html