netdev - Re: [PATCH net-next RFC] ipv4 neigh: match add/del dev lookup behaviour to SIOCSARP/SIOCDARP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1424788711.5565.78.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 24 Feb 2015 06:38:31 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"Rosen, Rami" <rami.rosen@...el.com>
Cc:	"roopa@...ulusnetworks.com" <roopa@...ulusnetworks.com>,
	"hadi@...atatu.com" <hadi@...atatu.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"hannes@...essinduktion.org" <hannes@...essinduktion.org>
Subject: Re: [PATCH net-next RFC] ipv4 neigh: match add/del dev lookup
 behaviour to SIOCSARP/SIOCDARP

On Tue, 2015-02-24 at 14:01 +0000, Rosen, Rami wrote:

> We can exit the method at this point with "return PTR_ERR(rt)" because we are assured at this point that dev is NULL.

Not sure it matters if dev is NULL or not :

We hold RTNL, and we do not have to hold/release dev.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html