lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <13A594FB-4232-4AC0-BADE-778B5D452633@gmail.com> Date: Tue, 24 Feb 2015 16:41:16 +0200 From: Eyal Birger <eyal.birger@...il.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: David Miller <davem@...emloft.net>, Shmulik Ladkani <shmulik.ladkani@...il.com>, Eric Dumazet <edumazet@...gle.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH net-next v3 3/4] net: use skb->priority for overloading skb->dropcount and skb->reserved_tailroom instead of skb->mark > On 24 Feb 2015, at 16:25, Eric Dumazet <eric.dumazet@...il.com> wrote: > > On Tue, 2015-02-24 at 16:07 +0200, Eyal Birger wrote: > >>> rxpc is buggy right now anyway, as it reads skb->mark _and_ uses >>> sock_recv_ts_and_drops(), so skb->mark value is pretty much void. >> >> Yes, but it does not seem to use sock_queue_rcv_skb() which sets skb->dropcount. > > Well, SO_RXQ_OVFL is broken for these sockets, as we'll report a > dropcount if skb->mark was set. > > Right. That feature seems broken. Fixing it would mean either avoiding the use of skb->mark in rxrpc or aliasing dropcount with something else. I am also not sure what should be the semantics of SO_RCVMARK on these sockets. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists