netdev - Re: [PATCH v2 1/2] rhashtable: require max_shift if grow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150224.211256.2012225739825347238.davem@davemloft.net>
Date:	Tue, 24 Feb 2015 21:12:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	daniel@...earbox.net, johunt@...mai.com, pablo@...filter.org,
	kaber@...sh.net, netfilter-devel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/2] rhashtable: require max_shift if grow_decision
 defined

From: Thomas Graf <tgraf@...g.ch>
Date: Tue, 24 Feb 2015 22:49:15 +0000

> On 02/24/15 at 04:31pm, David Miller wrote:
>> From: Daniel Borkmann <daniel@...earbox.net>
>> Let's fix as much crap as we can in -net.  I'm going to have to do
>> a huge backport of all the rhashtables to -stable at some point
>> too.
> 
> All fixes except 2-3 should only affect the post per bucket lock
> era. The fixes tags should be correct but I'll double check. I can
> take care of the backports if you like.

There were several bugs that are only cured by the "per bucket
lock era" version fo rhashtable.

I only applied all of that work to net-next at the time because
suspected we'd still have to hash all of that out.

Therefore, all of the rhashtable stuff that went into 4.0-rc1
is going to need to be backported.

I also really wish Herbert Xu didn't drop off the map on this work, we
could really use his expertiece and suggestions right now. :-/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html