netdev - Re: [PATCH net 1/1] cls_api.c: Fix dumping of non-existing actions' stats.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150224.211556.2272859487035151829.davem@davemloft.net>
Date:	Tue, 24 Feb 2015 21:15:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	cwang@...pensource.com
Cc:	ignacy.gawedzki@...en-communications.fr, netdev@...r.kernel.org
Subject: Re: [PATCH net 1/1] cls_api.c: Fix dumping of non-existing
 actions' stats.

From: Cong Wang <cwang@...pensource.com>
Date: Tue, 24 Feb 2015 16:20:42 -0800

> On Wed, Feb 4, 2015 at 8:26 PM, David Miller <davem@...emloft.net> wrote:
>> From: Ignacy Gawędzki <ignacy.gawedzki@...en-communications.fr>
>> Date: Tue, 3 Feb 2015 18:32:51 +0100
>>
>>> In tcf_exts_dump_stats(), ensure that exts->actions is not empty before
>>> accessing the first element of that list and calling tcf_action_copy_stats()
>>> on it.  This fixes some random segvs when adding filters of type "basic" with
>>> no particular action.
>>>
>>> This also fixes the dumping of those "no-action" filters, which more often
>>> than not made calls to tcf_action_copy_stats() fail and consequently netlink
>>> attributes added by the caller to be removed by a call to nla_nest_cancel().
>>>
>>> Signed-off-by: Ignacy Gawędzki <ignacy.gawedzki@...en-communications.fr>
>>
>> Applied, thanks.
> 
> Dave, please queue this patch for -stable as well, if you haven't done yet.
> It needs to backport back to 3.14.

Done.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html