lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Feb 2015 23:15:06 +0200 (EET) From: Julian Anastasov <ja@....bg> To: Alexander Duyck <alexander.h.duyck@...hat.com> cc: netdev@...r.kernel.org, davem@...emloft.net Subject: Re: [net-next PATCH 2/4] fib_trie: Replace plen with slen in leaf_info Hello, On Wed, 25 Feb 2015, Alexander Duyck wrote: > hlist_for_each_entry_rcu(li, &n->list, hlist) { > struct fib_alias *fa; > > - if ((key ^ n->key) & li->mask_plen) > + if (((key ^ n->key) >> li->slen) && > + ((BITS_PER_LONG > KEYLENGTH) || (li->slen != KEYLENGTH))) > continue; The '(BITS_PER_LONG > KEYLENGTH) ||' part is not needed because on 64-bit processor we can still use 32-bit register (due to 32-bit t_key type) and to get undefined (!0) result from rshift with 32. We do not want to continue in this case. Is it really working on 64-bit for 0.0.0.0/0 ? Regards -- Julian Anastasov <ja@....bg> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists