netdev - Re: [PATCH] e1000e: avoid incorrect ioremap/iounmap sequences for e1000_pch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1424899453.2622.2.camel@jtkirshe-mobl>
Date:	Wed, 25 Feb 2015 13:24:13 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	"John W. Linville" <linville@...driver.com>
Cc:	netdev@...r.kernel.org, David Ertman <david.m.ertman@...el.com>
Subject: Re: [PATCH] e1000e: avoid incorrect ioremap/iounmap sequences for
 e1000_pch_spt

On Wed, 2015-02-25 at 14:11 -0500, John W. Linville wrote:
> Commit 79849ebc0e06 (e1000e: initial support for i219) overwrites
> hw->flash_addr for e1000_pch_spt MACs without doing an iounmap.
> It also reuses the address without changing the areas that then
> iounmap the new address (which was never explicitly ioremap'ed).
> This causes iounmap to spit-out a call trace on rmmod.
> 
> This patch circumvents this issue on the early hardware that we have
> in-house at Red Hat.
> 
> Signed-off-by: John W. Linville <linville@...driver.com>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Cc: David Ertman <david.m.ertman@...el.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

Thanks John, your patch has been added to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)