netdev - Re: [PATCH net] e1000: add dummy allocator to fix race condition between mtu change and netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150225104540.GA26358@kria>
Date:	Wed, 25 Feb 2015 11:45:40 +0100
From:	Sabrina Dubroca <sd@...asysnail.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	jeffrey.t.kirsher@...el.com, linux.nics@...el.com,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] e1000: add dummy allocator to fix race condition
 between mtu change and netpoll

2015-02-25, 02:26:45 -0800, Eric Dumazet wrote:
> On Wed, 2015-02-25 at 11:05 +0100, Sabrina Dubroca wrote:
> > There is a race condition between e1000_change_mtu's cleanups and
> > netpoll, when we change the MTU across jumbo size:
> ...
> > 
> > Fixes: edbbb3ca1077 ("e1000: implement jumbo receive with partial descriptors")
> > Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>
> > ---
> >  drivers/net/ethernet/intel/e1000/e1000_main.c | 14 +++++++++++++-
> >  1 file changed, 13 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
> > index 7f997d36948f..5af866150671 100644
> > --- a/drivers/net/ethernet/intel/e1000/e1000_main.c
> > +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
> > @@ -144,6 +144,9 @@ static bool e1000_clean_rx_irq(struct e1000_adapter *adapter,
> >  static bool e1000_clean_jumbo_rx_irq(struct e1000_adapter *adapter,
> >  				     struct e1000_rx_ring *rx_ring,
> >  				     int *work_done, int work_to_do);
> > +static void e1000_alloc_dummy_rx_buffers(struct e1000_adapter *adapter,
> > +					 struct e1000_rx_ring *rx_ring,
> > +					 int cleaned_count);
> 
> Why are you using a forward declaration ?
> 
> Simply put here the body of this (dummy) function.

I wanted to match the style for the other allocators.  I'll send a v2.


Thanks,
-- 
Sabrina
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html