netdev - Re: [PATCH net-next 2/7] net: bluetooth: compact struct bt_skb_cb by converting boolean fields to bit fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHsH6GsMPoMKTF14uCLXWeqx=6o07egpHpBG4U07YNMiRpj8pA@mail.gmail.com>
Date:	Thu, 26 Feb 2015 15:22:32 +0200
From:	Eyal Birger <eyal.birger@...il.com>
To:	Shmulik Ladkani <shmulik.ladkani@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Willem de Bruijn <willemb@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Marcel Holtmann <marcel@...tmann.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/7] net: bluetooth: compact struct bt_skb_cb by
 converting boolean fields to bit fields

On Thu, Feb 26, 2015 at 9:30 AM, Shmulik Ladkani
<shmulik.ladkani@...il.com> wrote:
> On Thu, 26 Feb 2015 04:10:07 +0200 Eyal Birger <eyal.birger@...il.com> wrote:
>> @@ -277,11 +277,11 @@ typedef void (*hci_req_complete_t)(struct hci_dev *hdev, u8 status, u16 opcode);
>>
>>  struct bt_skb_cb {
>>       __u8 pkt_type;
>> -     __u8 incoming;
>>       __u16 opcode;
>>       __u16 expect;
>> -     __u8 force_active;
>> -     bool req_start;
>> +     __u8 force_active:1;
>> +     __u8 incoming:1;
>> +     __u8 req_start:1;
>>       u8 req_event;
>>       hci_req_complete_t req_complete;
>>       struct l2cap_chan *chan;
>
> There's a:
>     bt_cb(skb)->force_active = BT_POWER_FORCE_ACTIVE_ON;
> assignment in l2cap_core.c.
>
> No bluetooth expert, no idea if BT_POWER_FORCE_ACTIVE_ON is 1 by definition.
> If not, maybe prefer:
>     bt_cb(skb)->force_active = !!BT_POWER_FORCE_ACTIVE_ON
>

I think I can keep force_active as __u8.

Will update on v2.

Thanks!

> Besides that,
> Reviewed-by: Shmulik Ladkani <shmulik.ladkani@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html