netdev - Re: [PATCH net-next] bridge: fix link notification skb size calculation to include vlan ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bCQQTW0CigHLxLCc+pvMfD-bkVHZWP_5HR5J7cbbke6rw@mail.gmail.com>
Date:	Thu, 26 Feb 2015 06:13:40 -0800
From:	Scott Feldman <sfeldma@...il.com>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	"vyasevic@...hat.com" <vyasevic@...hat.com>,
	Wilson Kok <wkok@...ulusnetworks.com>,
	Siva Mannem <siva.mannem.lnx@...il.com>
Subject: Re: [PATCH net-next] bridge: fix link notification skb size
 calculation to include vlan ranges

On Wed, Feb 25, 2015 at 11:55 PM,  <roopa@...ulusnetworks.com> wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
>
> my previous patch skipped vlan range optimizations during skb size
> calculations for simplicity.
>
> This incremental patch considers vlan ranges during
> skb size calculations. This leads to a bit of code duplication
> in the fill and size calculation functions. But, I could not find a
> prettier way to do this. will take any suggestions.
>
> Previously, I had reused the existing br_get_link_af_size size calculation
> function to calculate skb size for notifications. Reusing it this time
> around creates some change in behaviour issues for the usual
> .get_link_af_size callback.
>
> This patch adds a new br_get_link_af_size_filtered() function to
> base the size calculation on the incoming filter flag and include
> vlan ranges.
>
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>

Reviewed-by: Scott Feldman <sfeldma@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html