netdev - Re: [PATCH] net: phy: b53: switchdev driver for Broadcom BCM53xx switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Feb 2015 16:30:00 +0100
From:	Rafał Miłecki <zajec5@...il.com>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	Florian Fainelli <f.fainelli@...il.com>,
	Andy Gospodarek <gospo@...ulusnetworks.com>,
	"David S. Miller" <davem@...emloft.net>,
	Network Development <netdev@...r.kernel.org>,
	Jonas Gorski <jogo@...nwrt.org>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	Felix Fietkau <nbd@...nwrt.org>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH] net: phy: b53: switchdev driver for Broadcom BCM53xx switches

On 26 February 2015 at 16:18, Andrew Lunn <andrew@...n.ch> wrote:
> On Thu, Feb 26, 2015 at 03:58:40PM +0100, Rafa?? Mi??ecki wrote:
>> On 25 February 2015 at 15:19, Andrew Lunn <andrew@...n.ch> wrote:
>> >> What do you mean by these recent patches? Has DSA recently received a
>> >> support for bridging ports in the hardware? Like setting VLANs using
>> >> some "bridge" comment (nl API) or something? Because I'm not aware of
>> >> that.
>> >
>> > Yes. Scan over netdev list for the last week. e.g:
>> >
>> > http://comments.gmane.org/gmane.linux.network/350754
>>
>> Hm, I can see it was actually merged to the net-next already:
>> https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=bb66be1c549a0760500cfad404b3d79a136d0e44
>>
>> But this dsa implementation is still totally unclear to me. So I can
>> see we now have
>> 1) port_join_bridge
>> 2) port_leave_bridge
>>
>> How does it allow me to bridge few ports with specifying PVID /
>> (UN)TAG for some of them?
>
> How about going back to the beginning. Look at the Starfigher 2 DSA
> driver. Do you have similar registers? Can you map the Starfigher code
> onto the b53 registers? If so, just write a new driver following the
> Starfigher as a reference.

It doesn't really answer my question as I don't see functionality I'm
looking for in bcm_sf2. I don't see it handling (un)tagging or PVID
anywhere. It makes me believe such features are not implemented (and
not configurable) using bridges/dsa at all. Can you any API related to
untagging / PVID?

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html