lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150226155512.GG1973@nanopsycho.lan> Date: Thu, 26 Feb 2015 16:55:12 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Brian King <brking@...ux.vnet.ibm.com> Cc: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>, netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org Subject: Re: [PATCH] ibmveth: Add function to enable live MAC address changes Thu, Feb 26, 2015 at 02:08:06PM CET, brking@...ux.vnet.ibm.com wrote: >On 02/25/2015 06:34 PM, Thomas Falcon wrote: >> @@ -1327,6 +1327,24 @@ static unsigned long ibmveth_get_desired_dma(struct vio_dev *vdev) >> return ret; >> } >> >> +static int ibmveth_set_mac_addr(struct net_device *dev, void *p) >> +{ >> + struct ibmveth_adapter *adapter = netdev_priv(dev); >> + struct sockaddr *addr = p; >> + u64 mac_address; >> + int rc; >> + >> + if (!is_valid_ether_addr(addr->sa_data)) >> + return -EADDRNOTAVAIL; >> + >> + ether_addr_copy(dev->dev_addr, addr->sa_data); >> + >> + mac_address = ibmveth_encode_mac_addr(dev->dev_addr); >> + rc = h_change_logical_lan_mac(adapter->vdev->unit_address, mac_address); >> + >> + return rc; > >Do you still want to be changing dev->dev_addr if h_change_logical_lan_mac >returns a failure? That should not be done. dev_addr should be in sync with real hw addr. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists