netdev - Re: [PATCH net-next 1/7] net: bluetooth: compact struct bt_skb_cb by inlining struct hci_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <8FC7DD28-25D4-4BB7-AB6F-13FC94E18176@holtmann.org>
Date:	Thu, 26 Feb 2015 08:15:05 -0800
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Eyal Birger <eyal.birger@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>, willemb@...gle.com,
	edumazet@...gle.com, shmulik.ladkani@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/7] net: bluetooth: compact struct bt_skb_cb by inlining struct hci_req_ctrl

Hi Eyal,

> struct hci_req_ctrl is never used outside of struct bt_skb_cb;
> Inlining it frees 8 bytes on a 64 bit system in skb->cb[] allowing
> the addition of more ancillary data.
> 
> Signed-off-by: Eyal Birger <eyal.birger@...il.com>
> ---
> include/net/bluetooth/bluetooth.h | 10 +++-------
> net/bluetooth/hci_core.c          | 12 ++++++------
> net/bluetooth/hci_event.c         |  4 ++--
> net/bluetooth/hci_request.c       |  6 +++---
> net/bluetooth/hci_sock.c          |  2 +-
> 5 files changed, 15 insertions(+), 19 deletions(-)

it would be a really good idea to actually send this to linux-bluetooth@...r.kernel.org for review.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html