netdev - Re: [PATCH] net: phy: b53: switchdev driver for Broadcom BCM53xx switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Feb 2015 17:21:47 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Rafa?? Mi??ecki <zajec5@...il.com>
Cc:	Florian Fainelli <f.fainelli@...il.com>,
	Andy Gospodarek <gospo@...ulusnetworks.com>,
	"David S. Miller" <davem@...emloft.net>,
	Network Development <netdev@...r.kernel.org>,
	Jonas Gorski <jogo@...nwrt.org>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	Felix Fietkau <nbd@...nwrt.org>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH] net: phy: b53: switchdev driver for Broadcom BCM53xx
 switches

On Thu, Feb 26, 2015 at 04:49:51PM +0100, Rafa?? Mi??ecki wrote:
> On 26 February 2015 at 16:36, Andrew Lunn <andrew@...n.ch> wrote:
> >> It doesn't really answer my question as I don't see functionality I'm
> >> looking for in bcm_sf2. I don't see it handling (un)tagging or PVID
> >> anywhere. It makes me believe such features are not implemented (and
> >> not configurable) using bridges/dsa at all. Can you any API related to
> >> untagging / PVID?
> >
> > The (un)tagging code is in net/dsa/tag_brcm.c This is generic code, so
> > you would not expect to find it in bcm_sf2. All you need to do is set
> >
> >         .tag_protocol           = DSA_TAG_PROTO_BRCM,
> >
> > in your dsa_switch_driver structure and the core DSA code will ensure
> > the packets gets the header applied/removed.
> 
> Sorry, I wasn't clear enough. I don't mean Broadcom proto tagging, but
> a 802.1Q VLAN header including e.g. VID.
> 
> I'd like to have control over VLAN ID ports are using. The hardware
> allows me to define VLAN with a number and also if:
> 1) Packets incoming on port X should be modified (by hw) to include
> 802.11Q header
> 2) Packets leaving port Y should be stripped out of 802.11Q header or not
> 
> Above allows me to create some fun setups. For example I can configure
> my Linux interface to send packets with VID N. Then I can tell
> hardware to:
> 1) Send packets with VID N untagged to port 1
> 2) Send packets with VID N still tagged to port 2

Ah, O.K.

DSA does not allow that, at the moment. The Marvell switches do
however support this. So i expect at some point it will get added.
This is actually a layer or two up. First you need plain packets
without 802.11q supported. Then you can add 802.11q on top of that,
using standard linux concepts. Then we can add ingress/egress VLAN tag
stripping/adding. This last part is maybe a new concept with linux,
since it is something we want in general, and not just when using the
SW bridge.

So lets say you have DSA slave interfaces lan1 and lan2

You could then do

vconfig add lan1 42 --strip
vconfig add lan2 42 

You could then add these lan1:42 and lan2:42 interfaces to the bridge
to get what you want?

    Andrew
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html