netdev - Re: [PATCH 1/1] xen-netback: remove compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150226.113046.199389136864969627.davem@davemloft.net>
Date:	Thu, 26 Feb 2015 11:30:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	marzo.pedro@...il.com
Cc:	ian.campbell@...rix.com, wei.liu2@...rix.com,
	xen-devel@...ts.xenproject.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] xen-netback: remove compilation warning

From: pedro <marzo.pedro@...il.com>
Date: Thu, 26 Feb 2015 09:25:41 +0100

> From: pmarzo <marzo.pedro@...il.com>
> 
> offset and size are of type uint16_t so the %lu gives a warning
> A %u specifier, the same used in size makes gcc happy
> Not sure if a %x would be more correct
> 
> Signed-off-by: Pedro Marzo Perez <marzo.pedro@...il.com>

This patch actually adds a warning on my machine, and your analysis
of the types is therefore probably incorrect:

drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’:
drivers/net/xen-netback/netback.c:1259:8: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 5 has type ‘long unsigned int’ [-Wformat=]

The issue is probably "~PAGE_MASK" and I think the type of that
propagates into the type of the overall calculation.