netdev - Re: [PATCH] net: phy: b53: switchdev driver for Broadcom BCM53xx switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54EF5E7D.7060504@gmail.com>
Date:	Thu, 26 Feb 2015 09:57:17 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Andrew Lunn <andrew@...n.ch>, Rafa?? Mi??ecki <zajec5@...il.com>
CC:	Andy Gospodarek <gospo@...ulusnetworks.com>,
	"David S. Miller" <davem@...emloft.net>,
	Network Development <netdev@...r.kernel.org>,
	Jonas Gorski <jogo@...nwrt.org>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	Felix Fietkau <nbd@...nwrt.org>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH] net: phy: b53: switchdev driver for Broadcom BCM53xx
 switches

On 26/02/15 07:36, Andrew Lunn wrote:
>> It doesn't really answer my question as I don't see functionality I'm
>> looking for in bcm_sf2. I don't see it handling (un)tagging or PVID
>> anywhere. It makes me believe such features are not implemented (and
>> not configurable) using bridges/dsa at all. Can you any API related to
>> untagging / PVID?
> 
> The (un)tagging code is in net/dsa/tag_brcm.c This is generic code, so
> you would not expect to find it in bcm_sf2. All you need to do is set
> 
>         .tag_protocol           = DSA_TAG_PROTO_BRCM,
> 
> in your dsa_switch_driver structure and the core DSA code will ensure
> the packets gets the header applied/removed.

This is untagging for the Broadcom tags, while Rafal is looking into
support the ndo_rx_vlan_{add,kill}_vid, which is something different here.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html