netdev - RE: [PATCH] Implement Hyper-V netvsc_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN1PR0301MB07706C93E34C1EA5F52770B4CA140@BN1PR0301MB0770.namprd03.prod.outlook.com>
Date:	Thu, 26 Feb 2015 21:01:45 +0000
From:	Haiyang Zhang <haiyangz@...rosoft.com>
To:	Andrew Schwartzmeyer <andrew@...wartzmeyer.com>
CC:	KY Srinivasan <kys@...rosoft.com>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"hall5714@...dals.uidaho.edu" <hall5714@...dals.uidaho.edu>,
	"keithd@...dals.uidaho.edu" <keithd@...dals.uidaho.edu>,
	"doma8101@...dals.uidaho.edu" <doma8101@...dals.uidaho.edu>
Subject: RE: [PATCH] Implement Hyper-V netvsc_get_channels() ethool op

> -----Original Message-----
> From: Andrew Schwartzmeyer [mailto:andrew@...wartzmeyer.com]
> Subject: [PATCH] Implement Hyper-V netvsc_get_channels() ethool op

Please add net-next to the subject (the patch should also be based on that tree).
Also the "hyperv: " word should come first.
Like this:
[PATCH net-next] hyperv: Implement netvsc_get_channels() ethool op

> --- a/drivers/net/hyperv/rndis_filter.c
> +++ b/drivers/net/hyperv/rndis_filter.c
> @@ -1094,6 +1094,7 @@ int rndis_filter_device_add(struct hv_device *dev,

On top part of this function, you also need to initialize max_chn = 1 around here:
        /* Initialize the rndis device */
        net_device = hv_get_drvdata(dev);
        net_device->num_chn = 1;

because the query for rsscap.num_recv_que is not done on all VSP versions.

Thanks,
- Haiyang

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html