netdev - Re: new link failing on duplicate names in different namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7Ocu7ig4NL+rrNq3szFBqKVRSSXhPiZDHP4tEzL6OSFzQ@mail.gmail.com>
Date:	Wed, 25 Feb 2015 21:56:57 -0800
From:	Cong Wang <cwang@...pensource.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Eugene Yakubovich <eugene.yakubovich@...eos.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: new link failing on duplicate names in different namespaces

On Wed, Feb 25, 2015 at 9:29 PM, Cong Wang <cwang@...pensource.com> wrote:
> On Wed, Feb 25, 2015 at 9:44 AM, Eric W. Biederman
> <ebiederm@...ssion.com> wrote:
>>
>> The code that creates a network devices fundamentally needs to know
>> about both namespaces network devices like the macvlan driver need
>> to find their lower devices in the original network namespace.
>>
>> I think we could possibly remove the restriction for the names of newly
>> created network devices being unique in both network namespaces but I
>> don't think the code changes will be trivial.
>>
>
> We should add a flag to network devices, so that some devices which
> don't have an underlying device, like veth, are allowed to be create right
> in the given netns. Or, of course, just modify rtnl_newlink() if we have
> some other clue (tb[IFLA_LINK] == NULL?).

Never mind, seems we only need to move the dest_net and link_net
up before checking duplicated.

Please give the attached patch a try.

View attachment "rtnetlink.patch" of type "text/x-patch" (6028 bytes)