netdev - Re: new link failing on duplicate names in different namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7Oz-g2BpAgC6V009BY=m9tGa6B7pE1b1iLqCq9814xddw@mail.gmail.com>
Date:	Thu, 26 Feb 2015 16:22:22 -0800
From:	Cong Wang <cwang@...pensource.com>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Eugene Yakubovich <eugene.yakubovich@...eos.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: new link failing on duplicate names in different namespaces

On Thu, Feb 26, 2015 at 1:14 AM, Nicolas Dichtel
<nicolas.dichtel@...nd.com> wrote:
> Le 26/02/2015 06:56, Cong Wang a écrit :
>>
>> On Wed, Feb 25, 2015 at 9:29 PM, Cong Wang <cwang@...pensource.com> wrote:
>
> [snip]
>>
>>
>> Please give the attached patch a try.
>>
> It's hard to comment a patch which is sent in attachment
> (see
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n333).
>


I knew, it is just not yet ready to submit formally. :)


> +                               err = rtnl_group_changelink(skb, dest_net,
> It should probably be something like 'link_net ? : dest_net' instead of
> dest_net.

I think it should be "link_net ?: net", since it is the source net.
And yes we need to pass the dest_net to this function as well as
do_setlink() too.


>
> I also don't understand why you need two label ('out' and 'err'). I think
> one is enough (link_net is initialized to NULL for this purpose).
> And why not keeping the same name as before, ie 'out'? It will minimize the
> patch.

Ah, right, I missed it.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html