netdev - Re: [Patch net] netns: correct gfp flags for alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Feb 2015 18:19:41 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Subject: Re: [Patch net] netns: correct gfp flags for alloc_netid()

On Thu, Feb 26, 2015 at 5:49 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Thu, 2015-02-26 at 16:54 -0800, Cong Wang wrote:
>> This fixes the following kernel warning:
>>
>>  ===============================
>>  [ INFO: suspicious RCU usage. ]
>>  3.19.0+ #805 Tainted: G        W
>>  -------------------------------
>>  include/linux/rcupdate.h:538 Illegal context switch in RCU read-side critical section!
>>
>>  other info that might help us debug this:
>>
>
> I do not think this is the right way to fix this.
>
> Bug is that rtnl_dump_ifinfo() should not use rcu_read_lock(), as RTNL
> is held : GFP_KERNEL allocations in control path should be the golden
> rule.
>
> I guess I should have reverted e67f88dd12f6 completely
> instead of the partial revert (2907c35ff647080)


LOL, it has been changed back and forth.

I thought rcu read lock was introduced to optimize dumping
performance, if it were really important, we should solve the
deadlock you mentioned in commit 2907c35ff647080?

Otherwise, as you said, completely revert to using rtnl lock.

Or for now just use my patch since idr doesn't allocate that
much memory in atomic?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html