lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <54F0AE0B.5080101@6wind.com> Date: Fri, 27 Feb 2015 18:48:59 +0100 From: Nicolas Dichtel <nicolas.dichtel@...nd.com> To: Cong Wang <xiyou.wangcong@...il.com> CC: Eric Dumazet <eric.dumazet@...il.com>, Linux Kernel Network Developers <netdev@...r.kernel.org> Subject: Re: [Patch net] netns: avoid allocating idr when dumping info Le 27/02/2015 18:28, Cong Wang a écrit : > On Fri, Feb 27, 2015 at 8:25 AM, Nicolas Dichtel > <nicolas.dichtel@...nd.com> wrote: >> Le 27/02/2015 09:01, Eric Dumazet a écrit : >> >>> On Thu, 2015-02-26 at 22:32 -0800, Cong Wang wrote: [snip] >>> >>> BTW, (void)peernet2id(dev_net(dev), src_net) can fail, and your fix is >>> not complete anyway. >> >> That's true. The patch does not cover the following case: >> ip link add foo type bar >> ip link set foo netns netns1 >> >> In this case, the second command will call dev_change_net_namespace() and >> the >> id will not be allocated. > > Then call it in do_setlink(). This is not a reason we _have to_ > allocate it in dumping. Sure, but that just shows the 'over engineering' side ;-) The reason to allocate it in dumping is that you need it in dumping, not before ;-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists