netdev - Re: [PATCH iproute2 v4] lib: Replace 16384 netlink buf size by macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150227174731.GA6949@angus-think.wlc.globallogic.com>
Date:	Fri, 27 Feb 2015 19:47:31 +0200
From:	Vadim Kochan <vadim4j@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	vadim4j@...il.com, stephen@...workplumber.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 v4] lib: Replace 16384 netlink buf size by macro

On Fri, Feb 27, 2015 at 12:38:31PM -0500, David Miller wrote:
> From: Vadim Kochan <vadim4j@...il.com>
> Date: Fri, 27 Feb 2015 08:31:40 +0200
> 
> > From: Vadim Kochan <vadim4j@...il.com>
> > 
> > Replaced hard coded 16384 netlink buffer size by NLBUF_SIZE,
> > which can be overridden by -DNLBUF_SIZE.
> > 
> > Signed-off-by: Vadim Kochan <vadim4j@...il.com>
> 
> I would like to know what problem is solved by changing this to
> any other value?
> 
> And then I would like to know why other potential solutions to
> this problem were not considered, such as making the buffer size
> dynamic and run-time selectable, perhaps with a size choosen
> in a manner to avoid whatever problem you hit with the current
> size.

Its just for the case when it might be changed in the future then it can be
easy found and changed. Just reject it if it looks useless. About
dynamic changing I think it makes sense to do it because memset is used
on the each netlink 16384 sized msg.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html