lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150227195443.GD24818@arm.com> Date: Fri, 27 Feb 2015 19:54:43 +0000 From: Will Deacon <will.deacon@....com> To: Daniel Borkmann <daniel@...earbox.net> Cc: "davem@...emloft.net" <davem@...emloft.net>, "ast@...mgrid.com" <ast@...mgrid.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Laura Abbott <lauraa@...eaurora.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next 09/10] arm64: unexport set_memory_ro and set_memory_rw On Fri, Feb 27, 2015 at 02:55:41PM +0000, Daniel Borkmann wrote: > This effectively unexports set_memory_ro and set_memory_rw functions from > commit 11d91a770f1f ("arm64: Add CONFIG_DEBUG_SET_MODULE_RONX support"). > > No module user of those is in mainline kernel and we explicitly do not want > modules to use these functions, as they i.e. protect eBPF (interpreted and > JIT'ed) images from malicious modifications or bugs. > > Outside of eBPF scope, I believe also other set_memory_* functions should > be unexported on arm64 for modules. > > Signed-off-by: Daniel Borkmann <daniel@...earbox.net> > Cc: Laura Abbott <lauraa@...eaurora.org> > Cc: Will Deacon <will.deacon@....com> > Cc: linux-kernel@...r.kernel.org > Acked-by: Alexei Starovoitov <ast@...mgrid.com> > --- > arch/arm64/mm/pageattr.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c > index bb0ea94..8659357 100644 > --- a/arch/arm64/mm/pageattr.c > +++ b/arch/arm64/mm/pageattr.c > @@ -70,7 +70,6 @@ int set_memory_ro(unsigned long addr, int numpages) > __pgprot(PTE_RDONLY), > __pgprot(PTE_WRITE)); > } > -EXPORT_SYMBOL_GPL(set_memory_ro); > > int set_memory_rw(unsigned long addr, int numpages) > { > @@ -78,7 +77,6 @@ int set_memory_rw(unsigned long addr, int numpages) > __pgprot(PTE_WRITE), > __pgprot(PTE_RDONLY)); > } > -EXPORT_SYMBOL_GPL(set_memory_rw); > > int set_memory_nx(unsigned long addr, int numpages) > { Looks good to me. Can this be applied independently, or does it need to remain part of your series? Will -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists